Skip to content

Add Progress Bar Component#49

Closed
TaqdeesHigh wants to merge 3 commits intoShaneBeeStudios:masterfrom
TaqdeesHigh:master
Closed

Add Progress Bar Component#49
TaqdeesHigh wants to merge 3 commits intoShaneBeeStudios:masterfrom
TaqdeesHigh:master

Conversation

@TaqdeesHigh
Copy link
Copy Markdown

@TaqdeesHigh TaqdeesHigh commented Mar 26, 2025

Implemented a progress bar that displays:

  • Current active step
  • Percentage of overall completion
  • Clear visual indication of progression

Changes include:

  • Step tracking
  • Percentage calculation

image

@ShaneBeee
Copy link
Copy Markdown
Member

ShaneBeee commented Mar 26, 2025

While Im super happy with the idea of the progress bar, I do have some concerns:

  1. This isn't really a concern but I have started doing some work on another branch, dev/patch, and thats probably going to cause a lot of conflicts with this.
    Could you please rebase onto that branch 😬

  2. The bar doesn't look so lovely on macOS.
    Probably just due to the fact this is a universal API, and macOS chose to do the bar differently.
    This isn't a huge concern as I'm sure most people using this app aren't on macOS.

Screenshot 2025-03-26 at 10 19 13 AM
  1. This one is a bigger concern. As Im sure you've already seen, the progress bar during the pre-processing state doesn't turn out well. The text is always "100%" all the while the bar is working backwards during the task.
    This is a hard one to manage since at the time the task has started, we don't know how many classes are going to be processed.
Screenshot 2025-03-26 at 10 04 39 AM Screenshot 2025-03-26 at 10 04 40 AM Screenshot 2025-03-26 at 10 04 45 AM

@TaqdeesHigh
Copy link
Copy Markdown
Author

TaqdeesHigh commented Mar 27, 2025

  1. Alright
  2. Yea i've only tested it on windows
  3. I've tried to fix it but its broken again idk why i'll try to fix it again.

@TaqdeesHigh
Added a totalClasses counter to track the total number of classes to …
0460ed3 
…process.

Never exceed 99% during preprocessing and decompiling stages
Ensure the progress starts from the beginning of the bar
Show 100% only when all classes are processed and decompiled

Track the total number of classes during preprocessing
Use the total classes as a denominator for progress calculation
@ShaneBeee ShaneBeee added the changes requested Changes have been requested for the PR author label Apr 6, 2025
@TaqdeesHigh TaqdeesHigh closed this by deleting the head repository May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changes requested Changes have been requested for the PR author

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TaqdeesHigh @ShaneBeee